[devcontainer] Add devcontainer setup#259
Open
CTKnight wants to merge 3 commits intosgl-project:mainfrom
Open
Conversation
Collaborator
|
I am not familiar with your PR. Please add a document to the usage. Then I can find someone to verify the utility. |
Author
|
@zhaochenyang20 Thanks for your comment! I have updated documentation for it. For your reference, attaching SGLang's documentation on devcontainer. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Add a VS Code devcontainer configuration so the repository can be opened directly in a preconfigured development environment with GPU support and a writable mounted workspace.
Test
Test env: WSL2 Ubuntu 22.04 with RTX 4090
I followed S2-Pro example to test https://cookbook.sglang.io/omni/S2-Pro#22-install-sglang-omni-inside-docker
uv pip install -v ".[s2pro,dev]"./playground/tts/start.sh --model-path /models/s2-proModifications
.devcontainer/Dockerfilebased on the existingfrankleeeee/sglang-omni:devimagedevuserthat can adapt to host UID/GID collisions and preserve write access on the bind-mounted workspacesudo, copy shell configuration, and exposeuvon the user PATH.devcontainer/devcontainer.jsonto build thedevtarget, mount the repo into/sgl-workspace/sglang-omni, enable--gpus all, set--shm-size 32g, and configure the Python VS Code extensionRelated Issues
N/A
Accuracy Test
N/A. This change only adds development-container configuration and does not modify model-side code.
Benchmark & Profiling
N/A. This change is not expected to affect runtime performance.
Checklist